Cache OCSP request fail for 5 minutes and display a better error (#2) #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#2)
This PR improves the SSL revocation test.
Sometimes, when we query the OCSP responder, we get a failure. Currently this failure is not cached so we will keep querying the OCSP responder (which might be temporary down).
This PR improves this by caching the error for 5 minutes, so that we won't put more load on the OCSP responder if he's not working properly at the moment.
In addition to that, the error message returned was improved in this situation to explain with it failed and to include the OCSP responder URI.
Here's what the error will look like now: